feat: harden finance tools input validation#184
Open
kiannidev wants to merge 3 commits intovirattt:mainfrom
Open
feat: harden finance tools input validation#184kiannidev wants to merge 3 commits intovirattt:mainfrom
kiannidev wants to merge 3 commits intovirattt:mainfrom
Conversation
Contributor
Author
|
Hi, maintainers |
DogInfantry
pushed a commit
to DogInfantry/dexter
that referenced
this pull request
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/tools/finance/validation.tsfor:normalizeTicker,validateTicker)validateLimit)validateDate,validateDateRange)report_period*filters via zod (validateReportPeriodFilters)stock-price.ts: validate ticker andstart_date/end_datebefore calling/prices/and/prices/snapshot/.fundamentals.ts: validate ticker, clamp/validatelimit, and validatereport_period_*filters before calling financial statement endpoints.key-ratios.ts: validate ticker, clamp/validatelimit, and validatereport_period*filters for historical key ratios.news.ts: validate ticker andlimit(1–10) before calling/news.insider_trades.ts: validate ticker,limit(1–1000), and filing date filters.estimates.ts: validate ticker before calling/analyst-estimates/.Testing
src/tools/finance/__tests__/validation.test.tswith coverage for:normalizeTickerandvalidateTicker(happy-path and error cases)validateLimit(in-range and out-of-range values)validateDate/validateDateRange(valid, malformed, and inverted ranges)validateReportPeriodFilters(undefined vs. invalid formats)bun test src/tools/finance/__tests__/validation.test.ts