vinumc: report errors line, column and text - #143
Open
artP2 wants to merge 2 commits into
Open
Conversation
Grillo-0
reviewed
Jun 11, 2026
Grillo-0
reviewed
Jun 11, 2026
Grillo-0
requested changes
Jun 11, 2026
artP2
force-pushed
the
report-errors
branch
3 times, most recently
from
June 25, 2026 23:13
22d0572 to
e52e813
Compare
artP2
force-pushed
the
report-errors
branch
2 times, most recently
from
July 29, 2026 12:50
5a34092 to
8ceb6ee
Compare
artP2
marked this pull request as ready for review
July 29, 2026 12:51
Contributor
Author
done |
JeanJPNM
requested changes
Aug 16, 2026
JeanJPNM
left a comment
JeanJPNM
left a comment
Member
There was a problem hiding this comment.
The error line has an incorrect value when this code is used as input.
[bar [other]
[a padded value]
[main: |[a]|]
[main]
input:1767992671:6: error: syntax error
1767992671 | [main]
| ^
I've tried to meaningfully reduce the size of the input, but this is the smallest sample I found that realiably causes this behavior.
Grillo-0
force-pushed
the
report-errors
branch
from
August 23, 2026 23:07
32a1b27 to
045591d
Compare
Member
@JeanJPNM @artP2 I solved it. We just need to zero initialize the lineno :P |
in the future we'll also have some error recovery test here
Grillo-0
force-pushed
the
report-errors
branch
from
August 23, 2026 23:10
045591d to
2d41c33
Compare
Grillo-0
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.