Skip to content

support unicode string display#77

Open
leslie-wang wants to merge 1 commit intoviktomas:mainfrom
leslie-wang:fix-unicode
Open

support unicode string display#77
leslie-wang wants to merge 1 commit intoviktomas:mainfrom
leslie-wang:fix-unicode

Conversation

@leslie-wang
Copy link
Copy Markdown
Contributor

Signed-off-by: Leslie Qi Wang leslie.qiwa@gmail.com

  • [Y] I've read Contribution guide
  • [T] I've tested everything that doesn't relate to tcell.Screen API

Screen Shot 2020-01-20 at 11 39 23 PM

Close #76

Close viktomas#76

Signed-off-by: Leslie Qi Wang <leslie.qiwa@gmail.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 21, 2020

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.21%. Comparing base (af23dd1) to head (5e545a7).
⚠️ Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
interactive/reporter.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #77      +/-   ##
===========================================
- Coverage   100.00%   99.21%   -0.79%     
===========================================
  Files            7        7              
  Lines          248      255       +7     
===========================================
+ Hits           248      253       +5     
- Misses           0        1       +1     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@viktomas
Copy link
Copy Markdown
Owner

@leslie-wang thanks for another contribution! It's great to see the handling of edge case like this. Please make sure you add tests for all code that you add.

Could you please check whether it would be possible to use the native range loop or the native utf8 library to avoid adding unnecessary dependencies?

@kanlac kanlac mentioned this pull request May 21, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unicode support

3 participants