Skip to content

HeapPriorityQueue.drv + capacity, toArray, toString #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

magicprinc
Copy link
Contributor

For consistency between FIFO and Heap queues:

I have added the same methods (capacity, toArray, toString) also for Heap Priority Queues.

Results of toArray, toString are not sorted (for implementation simplicity and performance)

@vigna
Copy link
Owner

vigna commented Jun 22, 2025

Argh I just released 😂

@vigna
Copy link
Owner

vigna commented Jun 22, 2025

Can you check that in the source you're using (4-space-width) TABs? I had to fix all spacing by hand in the previous PRs.

@magicprinc
Copy link
Contributor Author

magicprinc commented Jun 22, 2025

Strange!
I am a big fan of TAB as indent char (it is my default settting in IDEA)
Additionally IDEA shows me "Tab" as current indent in your project 🤷‍♀️

You can extra force rules with .editorconfig file in the root folder

# EditorConfig is awesome: https://EditorConfig.org

root = true

[*]
charset = utf-8
indent_style = tab
trim_trailing_whitespace = true
end_of_line = lf
insert_final_newline = false
spaces_around_operators = true
tab_width = 2
indent_size = 2

ij_continuation_indent_size = 2
ij_any_align_multiline_parameters = false

[*.yaml]
indent_style = space
tab_width = 2
[*.yml]
indent_style = space
tab_width = 2

#359

@magicprinc
Copy link
Contributor Author

magicprinc commented Jun 22, 2025

I have extra checked: it is TAB on my side 🤷‍♀️
screenshot
ve TAB, not spaces

@magicprinc
Copy link
Contributor Author

magicprinc commented Jun 22, 2025

screenshot
HeapPriorityQueue.drv uses TAB (I have double-checked)
FastByteArrayOutputStream also 👍
But ArrayFIFOQueue.drv somehow uses mix of tabs and spaces 🤦‍♂️

I think .editorconfig + my extra IDEA configuration (treat .drv as .java) must help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants