Skip to content

mdns: detect goodbye packets per RFC 6762 §11.3 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sohamukute wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mdns: detect goodbye packets per RFC 6762 §11.3 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compat/compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ enum {
MDNS_NETERR = -2, // network error
MDNS_LKPERR = -3, // lookup error
MDNS_ERROR = -4, // any runtime error that's not originating from the standard library
MDNS_GOODBYE = 1, // goodbye packet received (RFC 6762 §11.3, TTL=0)
};

/*
Expand Down
7 changes: 6 additions & 1 deletion src/mdns.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,12 @@ mdns_listen_probe_network(const struct mdns_ctx *ctx, const char *const names[],
for (struct rr_entry *entry = entries; entry; entry = entry->next) {
for (unsigned int i = 0; i < nb_names; ++i) {
if (!strrcmp(entry->name, names[i])) {
callback(p_cookie, r, entries);
/* RFC 6762 §11.3: TTL=0 is a goodbye packet */
if (entry->ttl == 0) {
callback(p_cookie, MDNS_GOODBYE, entries);
} else {
callback(p_cookie, r, entries);
}
break;
}
}
Expand Down