Repository navigation
Fixed Uncaught Error: Illegal component, "Vimeo"; with updated videojs[6.x.x] - #123
Open
santoshshinde2012 wants to merge 2 commits into
Open
santoshshinde2012 wants to merge 2 commits into
santoshshinde2012 wants to merge 2 commits into
Conversation
santoshshinde2012
changed the title
|
@gkatsev Please take a moment to analyze this solution |
djejaquino
approved these changes
Mar 26, 2018
djejaquino
left a comment
djejaquino
left a comment
There was a problem hiding this comment.
It works, but the code should be updated in order to user newer video.js versions.
|
This works for me in VideoJS 7.1.0. @gkatsev can you please review. |
|
When will this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the issues of Uncaught Error: Illegal component, "Vimeo"; with updated videojs[6.x.x] and src/vimeo.js not found