Conversation
Foundational skill for the robinhood-mcp connection. Pattern differs from slack-mcp/render-mcp because Robinhood exposes only an MCP server (JSON-RPC over HTTP), not a public REST API — so the skill teaches the agent the JSON-RPC envelope, the discover-then-call pattern, and Robinhood's hard constraints around trading. Safety guardrails baked in: read access spans every Robinhood account but trades can only land in the user's Agentic account, and every trade-placing tool surfaces a preview that the user must confirm before commit. The skill explicitly tells the agent not to auto-confirm. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
@greptile review |
…idance - Add the missing notifications/initialized step + Mcp-Session-Id header threading per the MCP Streamable HTTP spec. Without these, tools/list returns -32000 Server not initialized and the skill is non-functional as previously written. Also include MCP-Protocol-Version: 2025-06-18 on every request per spec. (Greptile P1.) - Add a modify/cancel section to match the frontmatter trigger list, including the order-ID lookup pattern, the "confirm before cancel" rule (no preview exists for cancels), and a guardrail against blanket "cancel all" calls. (Greptile P2.) Both flags verified against modelcontextprotocol.io/specification/2025-06-18. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
@greptile review |
The protocol section called it out as the failure mode for skipping the handshake or dropping Mcp-Session-Id, but the Errors table didn't list it. Add a row pointing back to the handshake steps. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Foundational provider skill for the `robinhood-mcp` connection landed in chorus. Lets agents look up the user's Robinhood positions and orders, research tickers, and place trades in the user's Agentic account.
Key Changes
Testing
Related
Companion chorus PR: vibecode/chorus#273
Note
Add Robinhood MCP provider skill documentation
Adds SKILL.md documenting the Robinhood MCP integration skill, including frontmatter metadata, account scope constraints, JSON-RPC over HTTP protocol usage examples, trade preview/confirm flow requirements, and common error handling guidance.
Macroscope summarized 5f37340. (Automatic summaries will resume when PR exits draft mode or review begins).
Greptile Summary
Adds
Foundational/vibecode-integration-robinhood-mcp/SKILL.md, a new provider skill that guides agents through the full Robinhood MCP integration — covering auth, account scope constraints, the JSON-RPC over Streamable HTTP session lifecycle, a discover-then-call pattern for tool discovery, and explicit safety guardrails for trading actions.initialize→notifications/initialized→tools/list→tools/callhandshake withMcp-Session-Idthreading, addressing both steps previously missing from an earlier draft.agent.robinhood.com) and banking (banking-agent.robinhood.com) endpoints with a warning against cross-server session reuse.Confidence Score: 5/5
Safe to merge — the skill document is complete, previously missing protocol steps are now present, and all destructive trade actions require explicit user confirmation.
The document correctly captures the full MCP session lifecycle, enforces the Agentic-account-only constraint, and provides explicit preview-then-confirm and cancel-confirmation guardrails. The only remaining gap is the shared SESSION_ID variable name for both servers, but the explicit prose warning covers the intent.
No files require special attention beyond the SESSION_ID variable naming note on SKILL.md.
Important Files Changed
Sequence Diagram
sequenceDiagram participant U as User participant A as Agent participant T as Trading Server participant B as Banking Server Note over A,T: Session initialization (once per turn) A->>T: POST /mcp/trading - initialize T-->>A: 200 OK + Mcp-Session-Id header A->>T: POST /mcp/trading - notifications/initialized T-->>A: 202 Accepted Note over A,T: Tool discovery A->>T: tools/list (Mcp-Session-Id: id) T-->>A: tool catalog Note over A,T: Place a trade A->>T: tools/call (place-trade) T-->>A: Preview A->>U: Show preview, ask confirmation U-->>A: Explicit yes A->>T: tools/call (confirm/submit) T-->>A: Order result Note over A,B: Banking - independent session A->>B: POST /mcp/banking - initialize B-->>A: 200 OK + separate Mcp-Session-Id A->>B: notifications/initialized B-->>A: 202 Accepted A->>B: tools/call (transfer/balance) B-->>A: ResultReviews (3): Last reviewed commit: "document -32000 Server not initialized r..." | Re-trigger Greptile