Skip to content

DATA-4220 Add EnableBackfill boolean to CreateDataPipeline #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DATA-4220 Add EnableBackfill boolean to CreateDataPipeline #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5ffbe9
enablebackfill typescript
gloriacai01 Jul 3, 2025
0f0b2b3
lint
gloriacai01 Jul 3, 2025
07c8604
linter
gloriacai01 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/app/data-client.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1430,6 +1430,7 @@ describe('DataPipelineClient tests', () => {
const schedule = '0 0 * * *';
const dataSourceTypeStandard = TabularDataSourceType.STANDARD;
const dataSourceTypeHotStorage = TabularDataSourceType.HOT_STORAGE;
const enableBackfill = true;

describe('listDataPipelines tests', () => {
const pipeline1 = new DataPipeline({
Expand Down Expand Up @@ -1538,6 +1539,7 @@ describe('DataPipelineClient tests', () => {
name: pipelineName,
mqlBinary: mqlQuery.map((value) => BSON.serialize(value)),
schedule,
enableBackfill,
dataSourceType: dataSourceTypeStandard,
});

Expand All @@ -1546,6 +1548,7 @@ describe('DataPipelineClient tests', () => {
pipelineName,
mqlQuery,
schedule,
enableBackfill,
dataSourceTypeStandard
);
expect(capReq).toStrictEqual(expectedRequest);
Expand All @@ -1558,14 +1561,16 @@ describe('DataPipelineClient tests', () => {
name: pipelineName,
mqlBinary: mqlQuery.map((value) => BSON.serialize(value)),
schedule,
enableBackfill,
dataSourceType: dataSourceTypeStandard,
});

const response = await subject().createDataPipeline(
organizationId,
pipelineName,
mqlQuery,
schedule
schedule,
enableBackfill
);
expect(capReq).toStrictEqual(expectedRequest);
expect(response).toEqual(pipelineId);
Expand Down
2 changes: 2 additions & 0 deletions src/app/data-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1417,6 +1417,7 @@ export class DataClient {
name: string,
query: Uint8Array[] | Record<string, Date | JsonValue>[],
schedule: string,
enableBackfill: boolean,
dataSourceType?: TabularDataSourceType
): Promise<string> {
const mqlBinary: Uint8Array[] =
Expand All @@ -1432,6 +1433,7 @@ export class DataClient {
name,
mqlBinary,
schedule,
enableBackfill,
dataSourceType: inputDataSourceType,
});
return resp.id;
Expand Down