make name public and export types for rendering #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheal-parks
approved these changes
Apr 16, 2025
stuqdog
approved these changes
Apr 17, 2025
purplenicole730
approved these changes
Apr 17, 2025
njooma
approved these changes
Apr 17, 2025
| @@ -10,8 +10,9 @@ import { MLModelService } from '../../gen/service/mlmodel/v1/mlmodel_connect'; | |||
|
|
|||
| export class MLModelClient implements MLModel { | |||
| private client: PromiseClient<typeof MLModelService>; | |||
| private readonly name: string; | |||
There was a problem hiding this comment.
Interesting. Not sure why it was private to begin with
There was a problem hiding this comment.
Normally this would be caught because we would extend Resource which requires name to be public. But the MLModelService does not implement the doCommand, which is a requirement for a Resource. So the type-checker didn't yell at me when I missed it last time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on the MLModel service test card, I noticed we were having some type issues with the client. First, the
namefield needed to be public. Second, we were missing some type exports that are pretty necessary to render anything from the metadata response. Shouldn't be anything breaking.