Skip to content

DOCS-3537: Add data code samples #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

DOCS-3537: Add data code samples #508

merged 3 commits into from
Apr 4, 2025

Conversation

npentrel
Copy link
Contributor

@npentrel npentrel commented Mar 27, 2025 •
edited
Loading

No description provided.

@npentrel npentrel requested a review from a team as a code owner March 27, 2025 20:14
@npentrel npentrel requested review from njooma and stuqdog March 27, 2025 20:14
@npentrel npentrel marked this pull request as draft March 27, 2025 21:12
@npentrel npentrel marked this pull request as ready for review March 27, 2025 22:35
njooma
njooma requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure this is up to date with main? This PR still uses BinaryID in a lot of places, and that has been deprecated

@npentrel npentrel requested a review from njooma April 2, 2025 09:28
@npentrel
Copy link
Contributor Author

npentrel commented Apr 2, 2025

Updated. It seems those changes merged the same day I requested review on this.

@npentrel npentrel merged commit 2ef0e46 into main Apr 4, 2025
3 checks passed
@npentrel npentrel deleted the DOCS-3535 branch April 4, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@stuqdog stuqdog Awaiting requested review from stuqdog stuqdog is a code owner automatically assigned from viamrobotics/sdk-netcode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@npentrel @njooma