Add actuating methods #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
reviewed
Feb 26, 2025
There was a problem hiding this comment.
Code looks reasonable to me! I wonder if it's not a bit safer to invert the logic here though? It's a bit more annoying for us to maintain but if a new method is added and we completely forget whether or not to consider the sessions aspect of it, it seems to me that it's safer to assume that we should have sessions and risk annoying/noisy error messages rather than assume that we shouldn't have sessions and risk that an actuating process continues after connectivity is lost.
|
Agreed -- see note in the python SDK PR as to why I did it this way instead of the inverse |
stuqdog
approved these changes
Feb 26, 2025
purplenicole730
approved these changes
Mar 3, 2025
njooma
force-pushed
the
RSDK-9328/non-actuating-session
branch
from
7659d1a to
9cbff9c
Compare
stuqdog
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone of viamrobotics/viam-python-sdk#857