Skip to content

Add React App and Tele-operation Example #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 20, 2024

Conversation

edaniels
Copy link
Contributor

@edaniels edaniels commented Sep 17, 2024

@DTCurrie you're my POC for this but feel free to re-assign.
@npentrel it might be worth running through the README to see if it makes sense

Notes:

  • The FA login page only shows email/password and I cannot do anything about that
  • FA machine control does not work yet as mentioned elsewhere and is a blocker for merge (@stevebriskin)
    • Need to be able to pass my FA access token to TS SDK (js supports this but TS SDK does not)
    • I need someone to file a ticket and let me know when this resolved

@edaniels edaniels requested a review from a team as a code owner September 17, 2024 16:39
@edaniels edaniels force-pushed the connect-app-teleop-react branch from 3917adf to 03b2298 Compare September 17, 2024 16:45
@edaniels edaniels requested a review from DTCurrie September 18, 2024 15:28
Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm though I don't think I necessarily have the context or TS experience to give a particularly meaningful review.

Copy link
Member

@DTCurrie DTCurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left some super-minor suggestions but none of them are blocking.

@edaniels
Copy link
Contributor Author

hi @lia-viam, did you want to review this?

@edaniels edaniels requested a review from npentrel September 19, 2024 11:38
Copy link
Contributor

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Eric!

@edaniels edaniels merged commit 75ff496 into viamrobotics:main Sep 20, 2024
3 checks passed
@edaniels edaniels deleted the connect-app-teleop-react branch September 20, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants