-
Notifications
You must be signed in to change notification settings - Fork 45
Add React App and Tele-operation Example #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add React App and Tele-operation Example #356
Conversation
3917adf
to
03b2298
Compare
Co-authored-by: Devin T. Currie <[email protected]>
examples/connect-app-teleop-react/frontend/components/locations-list.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/frontend/components/machine-parts-list.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm though I don't think I necessarily have the context or TS experience to give a particularly meaningful review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some super-minor suggestions but none of them are blocking.
examples/connect-app-teleop-react/src/components/locations-list.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/machine-part-control.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/machine-parts-list.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/machines-list.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/motion-arrows.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/motion-arrows.tsx
Outdated
Show resolved
Hide resolved
examples/connect-app-teleop-react/src/components/video-stream.tsx
Outdated
Show resolved
Hide resolved
…t.tsx Co-authored-by: Devin T. Currie <[email protected]>
…control.tsx Co-authored-by: Devin T. Currie <[email protected]>
…-list.tsx Co-authored-by: Devin T. Currie <[email protected]>
….tsx Co-authored-by: Devin T. Currie <[email protected]>
….tsx Co-authored-by: Devin T. Currie <[email protected]>
….tsx Co-authored-by: Devin T. Currie <[email protected]>
Co-authored-by: Devin T. Currie <[email protected]>
Co-authored-by: Devin T. Currie <[email protected]>
Co-authored-by: Naomi Pentrel <[email protected]>
Co-authored-by: Naomi Pentrel <[email protected]>
Co-authored-by: Naomi Pentrel <[email protected]>
hi @lia-viam, did you want to review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Eric!
@DTCurrie you're my POC for this but feel free to re-assign.
@npentrel it might be worth running through the README to see if it makes sense
Notes: