Return Uint8Array image from captureAllFromCamera #342
Conversation
| format: image.getFormat(), | ||
| sourceName: image.getSourceName(), | ||
| image: image.getImage_asU8(), |
There was a problem hiding this comment.
Is the return value of this function strictly typed? If so, all good. If not, this image response could drift if someone changed the image definition (e.g. added a new field to Image)
There was a problem hiding this comment.
It is, it's following the definition of Image and a return type error will be thrown by TSC if it doesn't adhere to it.
|
Just to add a little extra clarification: this is correcting a problem with the original implementation and aligning behavior with the go and python SDKs. Additionally this will help performance with a part of app that a potential customer is looking at. @stuqdog happen to know who would be a good reviewer on your team? Thanks in advance for any help! |
|
Thanks @njooma! |
Overview
Currently captureAllFromCamera returns a base64 encoded image from
captureAllFromCamera. This PR updates the method implementation so that a more efficientUint8Arrayis returned instead.