[RSDK-8045] [RSDK-8366] Simultaneous Auth for App and Machine

[njooma]

This PR enables getting a machine client from an already-authenticated Viam client.

It also introduces a few breaking changes, all of the same type: in the AppClient, there were many instances of methods returning pb.Response.AsObject rather than the actual type underneath the response, e.g. pb.Robot.AsObject:

// We were returning
return response.toObject()

// when we should've been returning
return response.toObject().robot

This PR also goes through and explicitly adds return types for app client so that we get compile-time errors in future.

Once this is approved, I will make an announcement regarding this breaking change. Specifically the functions that are affected are:

• getOrganization
• createOrganizationInvite
• updateOrganizationInviteAuthorizations
• resendOrganizationInvite
• createLocation
• getLocation
• updateLocation
• locationAuth
• createLocationSecret
• getRobot
• updateRobotPart
• createRobotPartSecret
• updateRobot
• getFragment
• createFragment
• updateFragment
• getRegistryItem
• getModule

[purplenicole730]

It took me a while to look through, but the changes look really good to me! I enjoyed seeing the improved tests.

[purplenicole730]

Following the previous functions, this return should be return response.getAuth()?.toObject(). The following functions after this one, however, follow this pattern of response.toObject()._. Wanted to point it out in case we had a preference.

[njooma]

I had changed some of them to be response.getFoo().toObject() and kept some as response.toObject().foo because I had a slight inkling that converting the entire message to a JS object would be slower than getting only the attribute we want and then calling toObject() on that. However, so many of these responses only had a single attribute that I figured it probably didn't actually make much of a difference.

I perhaps should've done some benchmarking instead of making assumptions...

[stuqdog]

lgtm

[purplenicole730]

Oh whoops, meant to approve with my comment.