feat: add mirroring of Almalinux 9 #34739
Draft
+46
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Update shell options for better error handling and tracing. - Add quotes around variables to prevent word splitting and globbing issues. - Replace for-loop with while-read for safer line-by-line processing. - Simplify upload error check by combining command and condition.
Update the workflow and publish script to handle multiple AlmaLinux OS versions (8 and 9).
Enhance trap commands with proper quoting to avoid potential word splitting issues. Add consistent quoting to variable expansions, preventing word splitting and globbing errors.
arnej27959
approved these changes
Sep 9, 2025
Member
arnej27959
left a comment
arnej27959
left a comment
There was a problem hiding this comment.
as far as i can see this should be OK
| COPR_PACKAGES=$(mktemp) | ||
| readonly COPR_PACKAGES | ||
| # shellcheck disable=SC2064 | ||
| trap "rm -f \"${COPR_PACKAGES}\"" EXIT |
Member
There was a problem hiding this comment.
do we even need to do this type of cleanup given that it's running inside a github action container which will be deleted when the script is done anyway? something to consider for later, maybe...
Contributor
Author
There was a problem hiding this comment.
Indeed, I did not question the process when I fixed the shellcheck warning.
gjoranv
approved these changes
Sep 10, 2025
Contributor
Author
|
Do not merge was set because this would bring us over the limit of the OSS storage offered by Cliudsmith. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why