drivers: rtc: mchp_g1: initialize unsupported rtc_time fields - #1
Draft
MilhoNerfado wants to merge 1 commit into
Draft
drivers: rtc: mchp_g1: initialize unsupported rtc_time fields#1MilhoNerfado wants to merge 1 commit into
MilhoNerfado wants to merge 1 commit into
Conversation
The get_alarm_time and get_clock_time functions were leaving tm_wday, tm_yday, tm_isdst, and tm_nsec uninitialized after populating the rtc_time struct. These fields are not backed by hardware registers, so callers would read indeterminate values. Set tm_wday, tm_yday, and tm_isdst to -1 (unsupported/unknown) and tm_nsec to 0, matching the convention used by other RTC drivers in Zephyr. Signed-off-by: Emilio Bottoni <emilio.bottoni@vertex.org.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The get_alarm_time and get_clock_time functions were leaving tm_wday, tm_yday, tm_isdst, and tm_nsec uninitialized after populating the rtc_time struct. These fields are not backed by hardware registers, so callers would read indeterminate values.
Set tm_wday, tm_yday, and tm_isdst to -1 (unsupported/unknown) and tm_nsec to 0, matching the convention used by other RTC drivers in Zephyr.