fix: replace misleading webui CORS error toast with generic network error message#2162
Open
benmcclelland wants to merge 1 commit into
Open
fix: replace misleading webui CORS error toast with generic network error message#2162benmcclelland wants to merge 1 commit into
benmcclelland wants to merge 1 commit into
Conversation
…rror message Browsers throw an opaque TypeError for all network-level failures — CORS policy violations, TLS/certificate rejections (e.g. self-signed certs), DNS failures, and unreachable hosts — with no way to distinguish between them. Asserting "CORS blocked" on every TypeError caused users to chase a CORS misconfiguration when the real problem was an untrusted certificate or unreachable gateway. The error message now lists some plausible causes so users have possible diagnostics regardless of the actual failure mode. Fixes #2143
benmcclelland
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers throw an opaque TypeError for all network-level failures — CORS policy violations, TLS/certificate rejections (e.g. self-signed certs), DNS failures, and unreachable hosts — with no way to distinguish between them. Asserting "CORS blocked" on every TypeError caused users to chase a CORS misconfiguration when the real problem was an untrusted certificate or unreachable gateway. The error message now lists some plausible causes so users have possible diagnostics regardless of the actual failure mode.
Fixes #2143