fix: expose x-amz-storage-class in CORS response headers#2159
Open
benmcclelland wants to merge 1 commit into
Open
fix: expose x-amz-storage-class in CORS response headers#2159benmcclelland wants to merge 1 commit into
benmcclelland wants to merge 1 commit into
Conversation
The object info modal in the WebUI was always displaying STANDARD as the
storage class regardless of the actual value. The root cause is a browser
CORS restriction: when the WebUI makes a cross-origin HEAD request to the
S3 endpoint, the browser silently drops any response header not listed in
Access-Control-Expose-Headers, causing response.headers.get('x-amz-storage-class')
to return null and the UI to fall back to the hardcoded STANDARD default.
Adding x-amz-storage-class to the default set of exposed headers ensures
the browser makes it available to JavaScript, allowing storage classes such
as GLACIER to be correctly reflected in the UI.
benmcclelland
force-pushed
the
ben/webui-storageclass
branch
from
a624a73 to
0e165ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The object info modal in the WebUI was always displaying STANDARD as the storage class regardless of the actual value. The root cause is a browser CORS restriction: when the WebUI makes a cross-origin HEAD request to the S3 endpoint, the browser silently drops any response header not listed in Access-Control-Expose-Headers, causing response.headers.get('x-amz-storage-class') to return null and the UI to fall back to the hardcoded STANDARD default.
Adding x-amz-storage-class to the default set of exposed headers ensures the browser makes it available to JavaScript, allowing storage classes such as GLACIER to be correctly reflected in the UI.