[18.0][MIG] report_py3o #12

Qlasta · 2025-04-15T08:40:27Z

task no. 25641
most of the changes copied from OCA PR, tested locally.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xml/

* No longer need `with Environment.manage()` * Assets are registered in manifest file now * ReportController endpoints no longer take a `token` parameter * The frontend ActionManager has been rewritten as an Owl service

Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xml/ca/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_xml/

Adds a way to choose the file extension for your XML file, by adding the flexibility of appending more choices. For example, instead of getting `.xml`, this allows to have the report download as `.svg` or even good old `.html` if needed. This is also very useful for some localization purposes, where some scarce software uses uncommon file extensions for their XML files, like `.ffdata` for specific accounting reports here in Lithuania. The change is not breaking, as we set the default to be `.xml` like it was by default anyway.

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/sv/

…eport files

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/

dz0

What was most complicated or needs more review attention?

Qlasta · 2025-04-16T06:47:43Z

[18.0][MIG] report_py3o

@dz0 can you just double check [18.0][MIG] report_py3o for any obvious mistakes.

dz0

So it is ported from v16 directly to v18?
Strange, that no v17 available around...

dz0 · 2025-04-16T07:15:09Z

report_py3o/controllers/main.py

-                data = list(url_decode(url.split("?")[1]).items())
+                data = list(MultiDict(parse_qs(url.split("?")[1])).items())


Why do you use MultiDict here?
it may lose some info if we have query from checkboxes-like form.
example qs: ?a=1&a=2&b=3

>>> md = MultiDict({"a":[1, 2], "b":3}) >>> md MultiDict([('a', 1), ('a', 2), ('b', 3)]) >>> list(md.items()) [('a', 1), ('b', 3)] # no more a=2 info

without Multidict it would be

>>> list({"a":[1, 2], "b":3}.items()) [('a', [1, 2]), ('b', 3)]

also can use parse_qsl variant:

data = parse_qsl(url.split("?")[1])

>>> mylist = parse_qsl("a=1&a=2&b=3") >>> mylist ... [('a', 1), ('a', 2), ('b', 3)] # If passed to dict, it will leave just **last** value of `a` (where's MultiDict leaves **first**) >>> dict(mylist) ... {'a': 2, 'b': 3}

I see later data is passed to report_routes

so depends how it will be handled futher -- inside of _render_qweb_[pdf/html/txt/xml]...?

and finally -- will it ever get those multiple param values?

Maybe final-decider would know?

If not clear: would leave at least comment (maybe link to this discussion).

@dz0, this I copied from OCA migration PR and also do not see any comment why it was changed. Although these changes was approved. Will try to check which format will be passed here, but I think will leave this change for now.

I checked a bit, but did not find out much. But as it is implemented similar way before the change, I think there shouldn't be multiple values for same parameter. Of course one can pass it still, but should expect to to work with multiple.

dz0 · 2025-04-16T07:44:48Z

report_py3o/static/src/js/py3oactionservice.esm.js

-                _.isUndefined(action.data) ||
-                _.isNull(action.data) ||
-                (_.isObject(action.data) && _.isEmpty(action.data))
+                action.data === undefined ||
+                action.data === null ||
+                (typeof action.data === "object" &&
+                    Object.keys(action.data).length === 0)


Here I see was used lodash -- is change needed to get rid of it?

This also was changed and approved from OCA

dz0 · 2025-04-16T07:46:24Z

report_py3o/static/src/js/py3oactionservice.esm.js

-                        context: JSON.stringify(env.services.user.context),
+                        context: JSON.stringify(action.context),


curious: how do you know that it should be action now?
any docs/log of API change?

This also was copied form orig.

oerp-odoo · 2025-04-16T09:15:21Z

report_py3o/tests/test_report_py3o.py

-from PyPDF2.pdf import PageObject
+
+try:
+    # For PyPDF2 <= 1.26.0


Is 18.0 still rely on olrder PyPDF2? if not, we should just assume latest version.

@oerp-odoo ir depends on python, maybe someone uses older versions: https://github.com/odoo/odoo/blob/18.0/requirements.txt#L57-L58. Or I should leave newer for our needs?

Well Odoo 18 enforces some minimum python, like I think its 3.10. So it might be that it is actually now impossible to use older PyPDF2 at all. Can you check if thats the case? If so, we can drop this check.

Oh I see 3.10 still includes older one:). Then lets keep it as is.

ernestotejeda and others added 30 commits January 10, 2025 10:26

[MIG] report_xml: Migration to 12.0

7550918

[UPD] Update report_xml.pot

6b9fc1f

Update translation files

beb76a2

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-12.0/reporting-engine-12.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-12-0/reporting-engine-12-0-report_xml/

[UPD] README.rst

d4aea5a

[IMP] report_xml: black, isort

8ecfe2f

[MIG][13.0] report_xml: Migration to 13.0

0cbb602

[UPD] Update report_xml.pot

2f08561

[UPD] README.rst

d80203a

Update translation files

18e2953

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xml/

Update translation files

bb68d65

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-13.0/reporting-engine-13.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-13-0/reporting-engine-13-0-report_xml/

[IMP] report_xml: black, isort, prettier

d737468

[MIG] report_xml: Migration to 14.0

849ea27

[UPD] Update report_xml.pot

1c0c32c

[UPD] README.rst

9801bb9

report_xml: context and safe_eval fix

0736a42

report_xml 14.0.1.0.1

a60d272

[IMP] report_xml: black, isort, prettier

b5af4e9

[MIG] report_xml: migrate 14 -> 15

854544f

* No longer need `with Environment.manage()` * Assets are registered in manifest file now * ReportController endpoints no longer take a `token` parameter * The frontend ActionManager has been rewritten as an Owl service

[UPD] Update report_xml.pot

fdbffad

[UPD] README.rst

c8115fd

[IMP] report_xml: Promote to Stable

3749734

[UPD] README.rst

1bc211a

report_xml 15.0.1.0.1

eb83f1d

Translated using Weblate (Catalan)

d735047

Currently translated at 94.4% (17 of 18 strings) Translation: reporting-engine-15.0/reporting-engine-15.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-15-0/reporting-engine-15-0-report_xml/ca/

[MIG] report_xml: Migration to 16.0

ef2e2d7

[UPD] Update report_xml.pot

e56e25d

[UPD] README.rst

af90895

Update translation files

49456ff

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: reporting-engine-16.0/reporting-engine-16.0-report_xml Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_xml/

[IMP] update dotfiles [ci skip]

3ef88f6

OCA-git-bot and others added 16 commits April 15, 2025 16:21

[BOT] post-merge updates

cc10815

Translated using Weblate (Italian)

d44eeda

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/

[IMP] remove python libs included in odoo from requirements

f246fc7

[BOT] post-merge updates

ef331bf

Translated using Weblate (Swedish)

9ae201b

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/sv/

[FIX] _py3o_parser_context: fix call to format_date in old_format_lang

e0cc98c

[BOT] post-merge updates

eeecf63

[FIX] report_py3o: change display_address() to _display_address()

a29ebb8

[IMP] report_py3o: use the standard file name behavior when zipping r…

d6756e5

…eport files

[BOT] post-merge updates

9daaf9e

[BOT] post-merge updates

9120e7c

Translated using Weblate (Italian)

971f96c

Currently translated at 100.0% (46 of 46 strings) Translation: reporting-engine-16.0/reporting-engine-16.0-report_py3o Translate-URL: https://translation.odoo-community.org/projects/reporting-engine-16-0/reporting-engine-16-0-report_py3o/it/

[IMP] report_py3o: refresh

d372588

[BOT] post-merge updates

5666b3f

[IMP] report_py3o: pre-commit auto fixes

99fb3bb

[18.0][MIG] report_py3o

b965830

Qlasta force-pushed the 18.0-mig-report-py3o branch from f0421f8 to b965830 Compare April 15, 2025 13:23

Qlasta marked this pull request as ready for review April 15, 2025 13:24

Qlasta requested review from a team and dz0 and removed request for a team April 15, 2025 13:25

dz0 reviewed Apr 16, 2025

View reviewed changes

Qlasta requested a review from dz0 April 16, 2025 07:42

dz0 approved these changes Apr 16, 2025

View reviewed changes

dz0 requested review from a team and oerp-odoo and removed request for a team April 16, 2025 07:53

oerp-odoo reviewed Apr 16, 2025

View reviewed changes

Qlasta merged commit b965830 into 18.0-versada Apr 16, 2025
4 checks passed

		data = list(url_decode(url.split("?")[1]).items())
		data = list(MultiDict(parse_qs(url.split("?")[1])).items())

		context: JSON.stringify(env.services.user.context),
		context: JSON.stringify(action.context),

[18.0][MIG] report_py3o #12

[18.0][MIG] report_py3o #12

Uh oh!

Conversation

Qlasta commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dz0 left a comment

Choose a reason for hiding this comment

Uh oh!

Qlasta commented Apr 16, 2025

Uh oh!

dz0 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oerp-odoo Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

20 participants

Qlasta commented Apr 15, 2025 •

edited

Loading

oerp-odoo Apr 16, 2025 •

edited

Loading