[17.0][FIX] product_secondary_unit: ensure qty persists.#10
Closed
Qlasta wants to merge 1 commit into17.0-versadafrom
Closed
[17.0][FIX] product_secondary_unit: ensure qty persists.#10Qlasta wants to merge 1 commit into17.0-versadafrom
Qlasta wants to merge 1 commit into17.0-versadafrom
Conversation
1dbb3ba to
cf94add
Compare
cf94add to
7ce6857
Compare
|
@Qlasta we should now create pull requests targeting OCA repo. And then use git-aggregator to combine it into final aggregated branch (you can see examples in repos.yml). So we should avoid |
Author
|
PR created on OCA repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem occurred after
sale_stockmodule update.task id - 26079
Description
After new
writemethod update insale.order.line, line change triggers sec uom qty calculation and test fails insale_order_secondary_unitmodule.Current Behaviour
Test fails:
Expected Behavior
Test does not fail. Setting secondary_uom_id on line (at the moment when secondary qty is not set), won't reset existing product_uom_qty .
Proposed implementation
Check if secondary_uom_qty exists, if not - do not continue calculation and do not reset qty.