Cleanups in RR graph generation #3264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
soheilshahrouz
changed the title
vpr/src/route/router_lookahead/router_lookahead_compressed_map.cpp
Outdated
Show resolved
Hide resolved
|
LGTM |
AmirhosseinPoolad
approved these changes
Sep 5, 2025
AlexandreSinger
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we want to iterate over all tile locations, we use a nested loop with three variables for x, y, and layer. This causes three levels of indentation. In RR graph generation code, additional conditional statements and loops incease indentation level to as high as 6-7, making some lines really long. This PR adds a new function to DeviceGrid to allow iterating over all tile location using a single loop.
In addition, the root location of tiles are passed in deep function call hierarchies using three separate arguments for x, y, and layer. I replaces these three arguments with a
t_physical_tile_locargument to make function calls more concise.I also changed the return type of
DeviceGrid::get_num_layers()tosize_tto be consistent withwidth()andheight()methods.