-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore(turbo-types): add ESM exports #10747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tknickman
wants to merge
19
commits into
main
Choose a base branch
from
tomknickman/turbo-4811-convert-turbotypes-to-esm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−108
Open
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6ed9225
chore(turbo-types): convert to ESM
tknickman 4787e8e
fix(turbo-types): add frameworks.json export for docs compatibility
tknickman f7ccec2
feat(turbo-types): add dual ESM/CommonJS build support
tknickman 0981ee8
Merge branch 'main' into tomknickman/turbo-4811-convert-turbotypes-to…
anthonyshew e8ae2c1
Simplification with bunchee.
anthonyshew e19eb1e
JSON resolution
anthonyshew daf33ed
WIP ecd44
anthonyshew 114cda9
WIP c44b5
anthonyshew 5377796
WIP c29b1
anthonyshew 266189e
Merge branch 'main' of https://github.com/vercel/turborepo into tomkn…
anthonyshew 6577be0
WIP 078a4
anthonyshew f25a9ff
WIP 8f88a
anthonyshew 5d0acde
WIP 58199
anthonyshew c3afb05
WIP 68a4c
anthonyshew 322812a
WIP 3cefe
anthonyshew ca9a5a2
WIP 2f4fa
anthonyshew 60409bf
WIP 434e5
anthonyshew c62ca1e
this should work
anthonyshew 33601fd
WIP effff
anthonyshew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
packages/turbo-types/.eslintrc.js → packages/turbo-types/.eslintrc.cjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| module.exports = { | ||
| extends: ["@turbo/eslint-config/library"], | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "extends": "@turbo/tsconfig/library.json", | ||
| "compilerOptions": { | ||
| "rootDir": "src", | ||
| "outDir": "dist/cjs", | ||
| "module": "CommonJS", | ||
| "moduleResolution": "node", | ||
| "target": "ES2020", | ||
| "lib": ["ES2020"], | ||
| "allowSyntheticDefaultImports": true, | ||
| "esModuleInterop": true, | ||
| "resolveJsonModule": true | ||
| }, | ||
| "include": ["src/**/*"], | ||
| "ts-node": { | ||
| "esm": false | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,12 @@ | ||
| { | ||
| "extends": "@turbo/tsconfig/library.json", | ||
| "compilerOptions": { | ||
| "rootDir": ".", | ||
| "rootDir": "src", | ||
| "outDir": "dist/esm", | ||
| "module": "ESNext", | ||
| "moduleResolution": "bundler", | ||
| "target": "ESNext", | ||
| "lib": ["ESNext"] | ||
| } | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "extends": "@turbo/tsconfig/library.json", | ||
| "compilerOptions": { | ||
| "rootDir": "src", | ||
| "outDir": "dist/types", | ||
| "declaration": true, | ||
| "emitDeclarationOnly": true, | ||
| "module": "ESNext", | ||
| "moduleResolution": "bundler", | ||
| "target": "ESNext", | ||
| "lib": ["ESNext"] | ||
| }, | ||
| "include": ["src/**/*"] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.