Skip to content

chore(deps): update dependency kysely to v0.28.8 #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency kysely to v0.28.8 #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/postgres-kysely/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,14 @@
"@types/node": "22.19.1",
"@types/ws": "8.5.13",
"jest": "29.7.0",
"kysely": "0.27.5",
"kysely": "0.28.8",
"ts-jest": "29.2.5",
"tsconfig": "workspace:*",
"tsup": "8.3.5",
"typescript": "5.7.3"
},
"peerDependencies": {
"kysely": "^0.24.2 || ^0.25.0 || ^0.26.0 || ^0.27.0"
"kysely": "^0.24.2 || ^0.25.0 || ^0.26.0 || ^0.27.0 || ^0.28.0"
Copy link
Contributor

@vercel vercel bot Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js engine requirement is incompatible with Kysely 0.28.8, which requires Node.js >=20.0.0. Users on Node.js 18 or 19 will fail to install this package.

View Details
📝 Patch Details 
diff --git a/packages/postgres-kysely/package.json b/packages/postgres-kysely/package.json
index 152de01..ea9a687 100644
--- a/packages/postgres-kysely/package.json
+++ b/packages/postgres-kysely/package.json
@@ -64,7 +64,7 @@
     "kysely": "^0.24.2 || ^0.25.0 || ^0.26.0 || ^0.27.0 || ^0.28.0"
   },
   "engines": {
-    "node": ">=18.14"
+    "node": ">=20.0.0"
   },
   "publishConfig": {
     "access": "public"

Analysis

Incorrect Node.js engine requirement in @vercel/postgres-kysely

What fails: The package declares "engines": { "node": ">=18.14" } but its peer dependency Kysely 0.28.8 requires node: >=20.0.0, creating a misleading compatibility claim.

How to reproduce: Check the package.json engine requirement vs. the peer dependency:

  • Package declares: "engines": { "node": ">=18.14" } (line 67 in packages/postgres-kysely/package.json)
  • Peer dependency resolved: [email protected] with engines: { "node": ">=20.0.0" } (verified in pnpm-lock.yaml line 2911)

Result:

  • Users on Node 18 or 19 installing this package with engine-strict configuration enabled will encounter installation failure with an engine mismatch error on the Kysely dependency
  • Even without strict checking, Node 18 users will have a misleading expectation that the package supports their version when it actually requires Node 20+
  • According to pnpm-lock.yaml, only Kysely 0.28.8 is resolved in the peer dependency range, which has the strict Node 20.0.0 requirement

Expected: The package should accurately declare the minimum Node version it actually requires. Since Kysely 0.28.8 is the latest version in the peer dependency range and requires Node 20+, the engines field should reflect this requirement to ensure accurate compatibility information for consumers.

},
"engines": {
"node": ">=18.14"
Expand Down
27 changes: 13 additions & 14 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading