Skip to content

chore: use trusted publishing for v1 releases#208

Merged
kakadiadarpan merged 4 commits into
v1.xfrom
darpan/backport-release-github-api-v1x
Jun 18, 2026
Merged

chore: use trusted publishing for v1 releases#208
kakadiadarpan merged 4 commits into
v1.xfrom
darpan/backport-release-github-api-v1x

Conversation

@kakadiadarpan

@kakadiadarpan kakadiadarpan commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Problem

  • v1 release publishing still used NPM_TOKEN_ELEVATED.
  • Release workflows were split across stable, v1, and snapshot files.
  • Changesets release commits could hit signed-commit rules.

Solution

  • Consolidate stable, v1 push, and snapshot release paths into .github/workflows/release.yml.
  • Use GitHub OIDC trusted publishing with provenance.
  • Use github-api Changesets commit mode.
  • Align v1 package repository metadata with main.

Related PR(s)

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
otel-site Ready Ready Preview, Comment, Open in v0 Jun 18, 2026 7:28pm

@socket-security

socket-security Bot commented Jun 18, 2026

Copy link
Copy Markdown

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

The single combined release workflow uses tokenless npm OIDC trusted publishing, but publishing runs through pnpm pinned at 9.4.0 (via packageManager), which predates pnpm's OIDC support — so both the release and release-snapshot publish steps fail with ENEEDAUTH/E401.

Fix on Vercel

Comment thread .github/workflows/release.yml Outdated
@kakadiadarpan kakadiadarpan requested a review from agadzik June 18, 2026 19:30
@kakadiadarpan kakadiadarpan marked this pull request as ready for review June 18, 2026 19:30
@kakadiadarpan kakadiadarpan requested a review from dvoytenko June 18, 2026 19:35
@kakadiadarpan kakadiadarpan merged commit e8de9b9 into v1.x Jun 18, 2026
9 checks passed
@kakadiadarpan kakadiadarpan deleted the darpan/backport-release-github-api-v1x branch June 18, 2026 19:40
kakadiadarpan added a commit that referenced this pull request Jun 18, 2026
## Problem
- v1 [release workflow
fails](https://github.com/vercel/otel/actions/runs/27784770764/job/82218536018)
in `pnpm/action-setup@v4`.
- Workflow set `version: 11.8.0` while `package.json` pins `pnpm@9.4.0`.
- Pushing to `v1.x` should not trigger a release automatically.

## Solution
- Remove explicit pnpm action version.
- Keep package manager pinned to `pnpm@9.4.0`.
- Keep release jobs on Node 22.
- Keep releases manual-only via `workflow_dispatch`.

## Related PR(s)
- #208
kakadiadarpan added a commit that referenced this pull request Jun 19, 2026
## Problem
- v1 release still uses older Changesets packages/action.
- v1 trusted publishing is failing after version PR merge.

## Solution
- Update `@changesets/cli` and `@changesets/changelog-github` to latest.
- Pin release workflow to latest `changesets/action` tag.
- Regenerate lockfile.

## Related PR(s)
- #208
- #209
- #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants