Fix: Keep metadata outlet consistent in prerender and resume #82540
+379
−37
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Default() { | ||
| return <div>Content</div> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { Suspense } from 'react' | ||
|
|
||
| async function AsyncComponent() { | ||
| await new Promise((resolve) => setTimeout(resolve, 100)) | ||
| return <div>Async content {Math.random()}</div> | ||
| } | ||
|
|
||
| export default function Page() { | ||
| return ( | ||
| <Suspense fallback={<div>Loading...</div>}> | ||
| <AsyncComponent /> | ||
| </Suspense> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Default() { | ||
| return null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { headers } from 'next/headers' | ||
| import { Metadata } from 'next' | ||
| import { unstable_noStore } from 'next/cache' | ||
|
|
||
| async function getChatIdFromHeaders() { | ||
| const headersList = await headers() | ||
| return headersList.get('x-chat-id') || 'default-id' | ||
| } | ||
|
|
||
| export async function generateMetadata(): Promise<Metadata> { | ||
| const chatId = await getChatIdFromHeaders() | ||
|
|
||
| // Simulate async DB call like v0 | ||
| await new Promise((resolve) => setTimeout(resolve, 100)) | ||
|
|
||
| return { | ||
| title: `Chat ${chatId}`, | ||
| description: `Chat session ${chatId}`, | ||
| } | ||
| } | ||
|
|
||
| export default async function ChatPage() { | ||
| unstable_noStore() | ||
|
|
||
| const chatId = await getChatIdFromHeaders() | ||
|
|
||
| if (!chatId) { | ||
| return <div>No chat ID</div> | ||
| } | ||
|
|
||
| // Simulate some async work | ||
| await new Promise((resolve) => setTimeout(resolve, 50)) | ||
| const random = Math.random() | ||
|
|
||
| return ( | ||
| <div> | ||
| <h1>Chat {chatId}</h1> | ||
| <p>Random: {random}</p> | ||
| </div> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Default() { | ||
| return null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Default() { | ||
| return null | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { Suspense } from 'react' | ||
|
|
||
| export default async function Layout({ | ||
| children, | ||
| content, | ||
| }: { | ||
| children: React.ReactNode | ||
| content: React.ReactNode | ||
| params: Promise<{ variants: string }> | ||
| }) { | ||
| return ( | ||
| <> | ||
| {children} | ||
| <Suspense>{content}</Suspense> | ||
| </> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { ReactNode, Suspense } from 'react' | ||
| export default function Root({ | ||
| children, | ||
| sidebar, | ||
| content, | ||
| }: { | ||
| children: ReactNode | ||
| sidebar: ReactNode | ||
| content: ReactNode | ||
| }) { | ||
| return ( | ||
| <html> | ||
| <body> | ||
| <Suspense> | ||
| {sidebar} | ||
| {children} | ||
| {content} | ||
| </Suspense> | ||
| </body> | ||
| </html> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| export default async function Page({ | ||
| searchParams, | ||
| }: { | ||
| searchParams: Promise<{ id: string | undefined }> | ||
| }) { | ||
| const { id } = await searchParams | ||
| const random = Math.random() | ||
| return ( | ||
| <p> | ||
| hello world {random} {id} | ||
| </p> | ||
| ) | ||
| } | ||
|
|
||
| export const generateMetadata = async () => { | ||
| return { | ||
| title: 'Hello World', | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export default async function Slot1() { | ||
| await new Promise((resolve) => setTimeout(resolve, 10)) | ||
| return <div>Slot 1</div> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export default async function Slot2() { | ||
| await new Promise((resolve) => setTimeout(resolve, 20)) | ||
| return <div>Slot 2</div> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| export default async function Slot3() { | ||
| await new Promise((resolve) => setTimeout(resolve, 30)) | ||
| return <div>Slot 3</div> | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
serveStreamingMetadatalogic has been hardcoded totrue, bypassing user agent detection and bot handling, which could cause incorrect behavior for different client types.View Details
📝 Patch Details
Analysis
The code has hardcoded
serveStreamingMetadata = trueand commented out the original logic that determined this value based on user agent detection and bot handling:This bypasses important logic that:
htmlLimitedBotsconfigurationAdditionally, the bot-specific logic
serveStreamingMetadata = falsefor HTML bots with PPR is also commented out, which could cause bots to receive streaming content when they should receive static content.Recommendation
Restore the original user agent detection logic and bot handling. If there are specific issues with the existing logic, they should be fixed properly rather than bypassed with hardcoded values. The changes should respect the existing API contracts and configuration options.