feat(third-parties): add consent management support to GoogleTagManager #80719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type prop to control script execution (application/javascript | text/plain) - Add support for data-* attributes for CMP platform integration - Support all major CMP platforms (Usercentrics, OneTrust, Cookiebot, Didomi) - Add comprehensive E2E tests for consent management scenarios - Update documentation with consent management examples - Maintain full backward compatibility Closes #XXXXX
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
…roach - Replace verbose individual tests with concise loop-based testing - Use structured test data for better maintainability - Reduce code duplication while maintaining comprehensive coverage - Improve readability and make it easier to add new CMP scenarios
NimaC
force-pushed
the
feat/gtm-consent-management
branch
from
2f03f8c to
3d4be75
Compare
…ative case - Reduce test complexity by using one CMP platform (Usercentrics) as representative - Remove redundant test cases since all CMPs follow the same pattern - Focus on testing core functionality: type prop and data-* attributes - Improve test maintainability and execution speed - Maintain comprehensive coverage of the feature being tested
NimaC
force-pushed
the
feat/gtm-consent-management
branch
from
7ee3691 to
9150e49
Compare
- Remove redundant standard GTM test from gtm-consent test case - Focus gtm-consent test only on new consent management functionality - Maintain proper separation of concerns between gtm.js and gtm-consent.js - Standard GTM behavior is already covered by existing gtm test - Consent management test now only validates type=text/plain and data-* attributes
…tative case - Replace multiple verbose code examples with one clear Usercentrics example - List other CMP platforms with their data attributes in concise format - Reduce documentation length while maintaining comprehensive coverage - Focus on the pattern rather than repetitive code blocks - Improve readability and maintainability of documentation
|
Hey @ijjk, thanks for reviewing this PR, its ready for a CI run now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds consent management support to GoogleTagManager component by making it more flexible to support different CMP integration approaches.
Why?
Component Inflexibility: The current GoogleTagManager component only supports standard script execution, but some CMPs require additional script attributes for integration. This forces developers to abandon the Next.js component for manual script injection.
CMP Integration Requirements: Some CMPs require:
type="text/plain"to prevent execution until consentdata-*attributes for identificationKnown Compatible CMPs:
data-cookieconsent="statistics"data-usercentrics="Google Tag Manager"How?
API (Backward Compatible):
Implementation:
typeprop for script execution controldata-*attributes for CMP integrationBenefits