Skip to content

[devtools] fix: error overlay closes when footer is clicked #80513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

[devtools] fix: error overlay closes when footer is clicked #80513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/next/src/next-devtools/dev-overlay/components/dialog/dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const CSS_SELECTORS_TO_EXCLUDE_ON_CLICK_OUTSIDE = [
'[data-info-popover]',
'[data-nextjs-devtools-panel-overlay]',
'[data-nextjs-devtools-panel-footer]',
'[data-nextjs-error-overlay-footer]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just use the existing .error-overlay-footer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classname could change over time (e.g., we decide to use Tailwind) compared to the data- attribute, so I think the data- attribute may serve better to target the element.

No strong push on this, though.

]

const Dialog: React.FC<DialogProps> = function Dialog({
Expand Down
2 changes: 1 addition & 1 deletion ...next-devtools/dev-overlay/components/errors/error-overlay-footer/error-overlay-footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export type ErrorOverlayFooterProps = {

export function ErrorOverlayFooter({ errorCode }: ErrorOverlayFooterProps) {
return (
<footer className="error-overlay-footer">
<footer data-nextjs-error-overlay-footer className="error-overlay-footer">
{errorCode ? (
<ErrorFeedback className="error-feedback" errorCode={errorCode} />
) : null}
Expand Down
Loading