Skip to content

fix: erase non-validatable 'as T' casts instead of SC1090 in --dynamic mode #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
techfreaque wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: erase non-validatable 'as T' casts instead of SC1090 in --dynamic mode #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions packages/compiler/src/frontend/lowering/lower-exprs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7147,15 +7147,12 @@ export function lowerTemplate(L: Lowerer, expr: ts.TemplateExpression): IrExpr {
if (targetTs.flags & ts.TypeFlags.Any) return inner;
const target = L.mapTypeOf(targetTs);
if (!target) L.badType(expr.type, targetTs);
if (!L.boundarySafe(target)) {
L.unsupported(
"SC1090",
expr,
`a checked cast of 'any' to '${L.fmt(target)}' ` +
`(an 'any' value can only be validated against JSON-representable types: ` +
`number, string, boolean, records, arrays, and unions of those)`,
);
}
// A target type that ITSELF maps to jsval — same erasure as the Any fast-path above.
if (target.kind === "jsval") return inner;
// Non-boundary-safe targets (functions, callable records, class instances, etc.)
// cannot be JSON-validated. JSVAL is already an opaque engine handle — the `as T`
// assertion is TypeScript-only and should erase rather than attempt validation.
if (!L.boundarySafe(target)) return inner;
return { kind: "jsExit", value: inner, type: target, loc: locOf(expr) };
}
const targetTs = L.checker.getTypeFromTypeNode(expr.type);
Expand Down