Unify command execution under shell - #520
Open
fazxes wants to merge 13 commits into
Open
Conversation
Replace the terminal and background command surfaces with one managed shell lifecycle. Preserve process ownership, PTY input, output replay, legacy session cleanup, and Ctrl-X visibility through the existing runtime boundaries.
Keep native captured-command admission unavailable when threads are absent and use a bounded tombstone counter supported by WASM.
|
Security review: https://vercel.slack.com/archives/C0BSEH6GB18/p1787978345590399 |
Remove scenarios for the deleted background command and keep one direct assertion that the old command is no longer registered.
Exercise the browser workspace through shell run and keep its strict completion-only boundary assertions current.
Keep help-menu and persistence fixtures aligned after removing the background command.
Document the completion-only shell run contract exposed by the embedded workspace.
Assert that unrecoverable legacy terminal calls resume as inert summaries without structured replay.
Assert structured command results and use the registered shell action in saved permission fixtures.
Propagate cancelled initial runs through the existing agent interruption path and align streamed TUI fixtures with shell results.
Use shell run in external path fixtures and assert structured command results in terminal-ownership coverage.
Stop benchmarking the deleted background command while preserving the existing startup budget.
Carry cancelled managed-command snapshots through the existing result boundary and update current shell fixtures across the full E2E matrix.
Stream managed output through the existing lifecycle edge, prioritize framed replay in Ctrl-O, and refresh the remaining current-shell E2E contracts.
fazxes
marked this pull request as ready for review
August 29, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary