Skip to content

feat(adapters): persist generated GitHub App keys - #205

Merged
Railly merged 3 commits into
mainfrom
feat/github-app-adapter-persistence
Aug 28, 2026
Merged

feat(adapters): persist generated GitHub App keys#205
Railly merged 3 commits into
mainfrom
feat/github-app-adapter-persistence

Conversation

@Railly

@Railly Railly commented Aug 19, 2026

Copy link
Copy Markdown
Member

Summary

  • generate omitted GitHub App private keys in the Next.js and Nuxt adapters
  • persist and restore one canonical identity across cold starts and concurrent instances
  • expose generated keys only through the server-side generatedSecrets() accessor
  • publish file snapshots atomically and preserve explicit-key and legacy-snapshot compatibility
  • document the complete embedded adapter workflow

Verification

  • pnpm build
  • pnpm type-check
  • pnpm test
  • pnpm lint
  • pnpm format:check
  • git diff --check
  • Test Strength: ten critical mutations killed; failed-save cleanup and HTTP header/body non-exposure coverage strengthened
  • Resilience Audit: ambiguous initialize/save success, transient load, malformed canonical state, save-queue recovery, and eight-way cold starts forced
  • pressure repetition: 10 rounds, 140 Next cases, 140 Nuxt cases, and 760 core cases without flakes
  • final Cursor Grok 4.6 xhigh review: zero actionable findings

Part of #203. This completes Slice 3; merge and release remain maintainer-controlled.

@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
emulate Ready Ready Preview, v0 Aug 25, 2026 10:14pm

Deduplicate the Next and Nuxt implementation and regression contract while preserving generated GitHub App identity behavior.
Comment thread packages/@emulators/core/src/adapter-runtime.ts Outdated
@Railly
Railly merged commit e4d6657 into main Aug 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants