Add first-class Kimi K3 support through Fireworks - #134
Open
WadeWarren wants to merge 1 commit into
Open
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
WadeWarren
force-pushed
the
wade/kimi-k3-fireworks
branch
from
July 29, 2026 19:57
2fa4b96 to
e8954be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added a first-class Pi preset for Kimi K3 on Fireworks, including offline model registration, local and sandbox credential routing, regression coverage, and setup/model documentation.
Why
Pi's bundled Fireworks catalog predates Kimi K3, so using
fireworks/accounts/fireworks/models/kimi-k3currently requires every user to maintain a privatemodels.jsonentry. This compatibility overlay makes the model work with onlyFIREWORKS_API_KEY, preserves existing Fireworks models and explicit overrides, and becomes a no-op when a future Pi catalog includes the model.Verification
pnpm testpasses — 2,256 tests passed, 1 credential-gated live-sandbox test skippedpnpm lintpassespnpm knippassespnpm test:bundlepasses — 23 testspnpm test:e2epasses — 29 tests, 1 credential-gated live-sandbox test skippedpnpm validatepassesmodels.jsonThe final live smoke processed one intentionally vulnerable fixture with Kimi K3 at low thinking and concurrency 1. It completed one tool-using analysis in 23.4 seconds, returned four findings, recorded 3,426 input / 869 output tokens at $0.0239274, produced no refusal or parse failure, and did not persist the Fireworks credential.
Notes for reviewer
The preset is exact-model scoped and does not change any default model. It merges Kimi K3 into Pi's existing Fireworks catalog only when the model is missing, preserves an existing exact-model custom endpoint, retains explicit base URL/key/header overrides, and sends sandbox workers only a placeholder token while the firewall injects the real credential on
api.fireworks.ai.Model metadata and pricing follow the Fireworks Kimi K3 listing; the endpoint follows Fireworks' OpenAI compatibility documentation.