Closed
Conversation
NinjaLikesCheez
requested changes
Aug 7, 2025
| do { | ||
| value = try T(from: decoder) | ||
| } catch { | ||
| logger.error("Failed to decode \(T.self): \(error)") |
Collaborator
There was a problem hiding this comment.
I worry this isn't enough of a warning that we're failing to determine a dependency. We should be pretty aggressive here, without dependencies (or a very stern warning) you may think you're scanning everything, when we're failing to make a link between two dependencies
Collaborator
Author
There was a problem hiding this comment.
I was unsure also whether to even add this change. It looked to me like it might be a corrupt PIF but I wasn't sure. I did ask the customer to try with a clean PIF and if it still failed to try and clean up the dependency in Xcode (see https://veracode.atlassian.net/browse/ENG-61598?focusedCommentId=1328164). So, I'll just drop this branch and leave the failure for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow Gen-IR to continue on dependency decode error.