feat: create a new ScalarLeafsRuleWithoutSuggestions validator rule#413
Open
XuankangLin wants to merge 1 commit intovektah:masterfrom
Open
feat: create a new ScalarLeafsRuleWithoutSuggestions validator rule#413XuankangLin wants to merge 1 commit intovektah:masterfrom
XuankangLin wants to merge 1 commit intovektah:masterfrom
Conversation
ScalarLeafsRule also appends "Did you mean" schema suggestions like e.g., KnownTypeNamesRule, but wasn't treated previously like other validator rules, possibly because it was calling `Suggestf()` which adds the "Did you mean" string.
XuankangLin
force-pushed
the
scalar_leafs_without_suggestion
branch
from
44993c6 to
21fd3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScalarLeafsRule also appends "Did you mean" schema suggestions like e.g., KnownTypeNamesRule, but wasn't treated previously like other validator rules, possibly because it was calling
Suggestf()which adds the "Did you mean" string indirectly.I have:
[N/A] Added tests covering the bug / feature.
[N/A] Updated any relevant documentation