ws2812 change from opendrain to push_pull output #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with open drain the driver doesn't work very well on hardware with inline resistance between the stm32 and output pins. Changing to push_pull output means it works reliably with a 1k resistor inline for pin protection.
Owner
|
The reason for opendrain is that some (most) LEDs require more than 3.3V on the data-pin. On 5V-tolerant pins (most are) you can use a pull-up to 5V and opendrain to make it work. If the pins are in push-pull the simple pull-up trick won't work. Maybe there should be an option to switch between open-drain and push-pull? |
Author
|
The leds I am using say 0.7xVcc so 3.5v but seems to work fine with 3.3v. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with open drain the driver doesn't work on hardware with inline resistance between the stm32 and output pins. Changing to push_pull output means it works reliably with a 1k resistor inline for pin protection.