enhancement(nats source): call drain()
during shutdown
#23635
Merged
+119
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the NATS source to drain messages when shutting down. Currently we unsubscribe, which is not as robust as draining before disconnect since inflight messages can be dropped.
More details here: https://docs.nats.io/using-nats/developer/receiving/drain
How did you test this PR?
Ran this on a relatively high velocity NATS subject (messages redacted, but timestamp is the native timestamp created by Vector) with a console sink to stdout.
With this change, events are still handled even after the shutdown is triggered.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
Not sure about this one, I guess technically it's user-facing?
no-changelog
label to this PR.References