-
Notifications
You must be signed in to change notification settings - Fork 5
[REFACTOR] 상세페이지 쿼리키 무효화 점검 및 상세페이지 id 오류 해결 #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 적용하여 반응형 수정 완료
…ailId로 넘기는 것으로 변경
jinj00oo
approved these changes
Aug 22, 2025
Collaborator
jinj00oo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트 글 제목에서 노력의 흔적(?)이 보이네요!! ㅋㅋㅋ 원인 파악하고 고치시느라 수고 많으셨습니다
sunhwaaRj
approved these changes
Aug 22, 2025
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
쿼리키때문이 아니었네요.....짱
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크리스트
📌 관련 이슈번호
✅ Key Changes
기존 문제점
DetailHeader,WorkspaceDetailHeader)의 id가 다음 생성될 목표/이슈의 id로 나타나는 문제가 있었습니다.원인 파악
DetailHeader,WorkspaceDetailHeader) 내부에서 항상 다음 생성될 목표/이슈/외부 이름을 조회하는 API 훅을 호출하고, 그로부터 받은 이름을 id값으로 적용하고 있었기 때문에 무조건 생성될 id가 뜨고 있었습니다.오류 해결
DetailHeader,WorkspaceDetailHeader) 내부에서 생성될 목표/이슈/외부 이름을 조회하는 API 훅을 호출하는 로직을 제거하고,props로 부모 컴포넌트로부터 받아올detailId를 추가했습니다.GoalDetail,IssueDetail,ExternalDetail등)에서 불러옵니다.detailId로 연결.detailId로 연결.📸 스크린샷 or 실행영상
(1) 해당 팀내의 목표 목록을 보면 기존 g1~g6까지의 목표들이 생성되어있었음
(2) 새로 목표를 생성하면 생성될 목표 이름 조회 API 훅을 통해, 신규 목표 id(g7)이 나타남
(3) 목표 생성 완료 후 다시 해당 목표로 돌아와도: 다음 생성될 목표 id(g8)이 뜨는 오류는 사라지고, 기존 id(g7) 그대로 보임
(4) 기존에 생성된 목표의 경우에도 기존 id값(g5)이 제대로 보임
💬 To Reviewers