Fix propagation of PyTorch CUDA flags for multiple archs #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #57, the extra CUDA flags generated from PyTorch were transferred from the
CUDA_NVCC_FLAGSvariable to the proper target. However, the same modification for theCMAKE_CUDA_FLAGSvariable was overlooked, resulting in duplicated flags. Furthermore, when multiple CUDA architectures are present, the flags were not correctly passed to the compiler. Make the extraction logic more robust and add a respective test case to cover this case as well.