Repository navigation
fix: skip SVG scans for unrelated modules - #127
Closed
boy-twilight-lee wants to merge 1 commit into
Closed
boy-twilight-lee wants to merge 1 commit into
boy-twilight-lee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126.
The load hook currently calls createModuleCode for unrelated modules during builds and development SSR requests. Each call walks the SVG directories and checks file metadata even when the generated module is discarded.
Return null for unrelated IDs before generating module code. Keep the existing suffix matching, virtual module output, and development/SSR behavior; remove the now-redundant virtual-module check from the SSR branch.
Add regression tests using a real SVG fixture and a spy on fast-glob.sync. They verify zero scans for unrelated TS, Vue, CSS, dependency, and virtual modules, plus the output and scan counts for both SVG virtual modules, including null-prefixed IDs.
Validation:
The full pnpm exec tsc --noEmit check is blocked by an existing dependency declaration issue: rollup-plugin-esbuild references the missing ts-essentials package. No dependency or lockfile changes are included.