Fix Microsoft Teams screensharing click vs drag issue on Windows and Chrome #384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks for the great repo! The performance is great and easy to use.
This PR fixes a minor issue when screen-sharing through Teams on Windows and Chrome.
I noticed every time screen-share mode is on there is always an extra
pointermoveevent. This put the
isPointerDraggingstate always intotrue. This ensureswhen the movement is below our tolerance we reset the dragging state off
allowing us to catch
onNodeClickevent.Context: This tolerance commit
Fixes vasturiano/react-force-graph#383 and vasturiano/react-force-graph#425
Reproduce
Launch Microsoft Teams and start screen-sharing and target the chrome window
with the graph. In your
handleClickandhandleDragtry to log the eventsthat happens. You will see that it always output "drag" even after the tolerance fix.
You can see pointer events using this in Chrome console
monitorEvents(document.querySelector('canvas'), 'pointer')