Name ecommerce.items parameter names in purchase event GA4-compliant - #7
Open
wmdkfhartung wants to merge 424 commits into
Open
Name ecommerce.items parameter names in purchase event GA4-compliant#7wmdkfhartung wants to merge 424 commits into
wmdkfhartung wants to merge 424 commits into
Conversation
|
In coordination with the initial author of the module, we are currently continuing the development. Therefore, please feel free to use our fork (https://github.com/d3datadevelopment/GoogleAnalytics4/) for your collaboration. The changes can be returned to the parent repository at any time. However, I would not expect this. |
# Conflicts: # CHANGELOG.md
# Conflicts: # Application/views/admin/de/module_options.php # Application/views/ga4/view_item_list.tpl # CHANGELOG.md # Modules/Core/ViewConfig.php # composer.json # metadata.php
deny method-call on no category
…to dev_1.x # Conflicts: # metadata.php
making sure that begin_checkout is always rolled out
- add item_brand to all events - add option to use real category titles instead of url parts for item_categoryX - add option to replace chars in item_categoryX values thanks to Stefan Moisees@beffy@proudcommerce.com
if activated but no chars are given, it'll cut out the whole category-string -> added char-check
by Florian Palme <info@florian-palme.de>
since it doesn't work properly currently and requires a greater fixup
and removed unnecessary code/ try-outs
…whitespaces in container ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently some of the items parameter names in the purchase event are not named GA4 compliant. (https://github.com/d3datadevelopment/GoogleAnalytics4/blob/master/Application/views/blocks/checkout_s5.tpl)
So they are called "id, name, variant", although they should be called "item_id, item_name, item_variant". (See https://developers.google.com/analytics/devguides/collection/ga4/set-up-ecommerce?hl=de#add-event)
In the view_item, add_to_cart and view_cart event they are named correctly.