Fix GetStringArray and GetFloatArray test signatures for issue #62#112
Draft
ljluestc wants to merge 1 commit intovalyala:masterfrom
Draft
Fix GetStringArray and GetFloatArray test signatures for issue #62#112ljluestc wants to merge 1 commit intovalyala:masterfrom
ljluestc wants to merge 1 commit intovalyala:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated TestValue_GetStringArray and TestValue_GetFloatArray to handle two return values (got, err := v.Get(tt.path).GetStringArray() and GetFloatArray()).
Kept name, wantErr, and errMsg fields for clear test cases and error validation.
Ensured reflect.DeepEqual compares slices only after error checks.
Preserved TestValue_GetRawString and other tests.