Skip to content

EMP-323: Add publish from PR#161

Merged
A77AY merged 13 commits intomasterfrom
ft/new-frontend-pr
Mar 27, 2025
Merged

EMP-323: Add publish from PR#161
A77AY merged 13 commits intomasterfrom
ft/new-frontend-pr

Conversation

@A77AY
Copy link
Contributor

@A77AY A77AY commented Mar 26, 2025

No description provided.

@A77AY A77AY requested a review from Copilot March 26, 2025 19:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds composite actions to set up NodeJS and publish packages to NPM, while updating frontend workflows to integrate these new actions.

  • Added a NodeJS setup action (.github/actions/setup/action.yaml).
  • Added an NPM publish action (.github/actions/publish/action.yaml) with version handling.
  • Updated workflow files (.github/workflows/frontend-pr.yml and .github/workflows/frontend-publish.yml) to incorporate the new actions.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/actions/setup/action.yaml Defines a composite action to configure NodeJS.
.github/actions/publish/action.yaml Implements a composite action for publishing to NPM.
.github/workflows/frontend-pr.yml Updates PR workflow to use the new setup and publish actions.
.github/workflows/frontend-publish.yml Adjusts publish workflow to integrate with new action versions.
Comments suppressed due to low confidence (1)

.github/actions/publish/action.yaml:8

  • [nitpick] The input name 'version-not-up' is ambiguous; consider renaming it to 'skip-version-update' for improved clarity.
  version-not-up:

@A77AY A77AY requested a review from Copilot March 26, 2025 19:56
@A77AY A77AY added the publish label Mar 26, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the "Publish from PR" feature by introducing a new GitHub Action for publishing to NPM and updating existing workflows to integrate the new actions.

  • Added a new composite action (.github/actions/publish/action.yaml) that handles publishing with version bumping based on PR events.
  • Introduced a NodeJS setup action (.github/actions/setup/action.yaml) and updated workflow files for frontend PRs and publishing.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
.github/actions/publish/action.yaml New composite action for handling NPM publishing.
.github/actions/setup/action.yaml New composite action for NodeJS setup and dependency install.
.github/workflows/frontend-pr.yml Updated workflow to integrate the new publish action for PRs.
.github/workflows/frontend-publish.yml Revised publish workflow configuration.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@A77AY A77AY removed the publish label Mar 26, 2025
@A77AY A77AY added the publish label Mar 26, 2025
@A77AY A77AY merged commit ecf4977 into master Mar 27, 2025
4 of 6 checks passed
@A77AY A77AY deleted the ft/new-frontend-pr branch March 27, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants