Skip to content

fix: update tests/e2e noteabooks api hostname#516

Merged
eggshell merged 1 commit into
mainfrom
cullen/sc-15688/flatten-ingress
May 20, 2026
Merged

fix: update tests/e2e noteabooks api hostname#516
eggshell merged 1 commit into
mainfrom
cullen/sc-15688/flatten-ingress

Conversation

@eggshell
Copy link
Copy Markdown
Contributor

api now lives under the app. hostname. This will resolve that.

Pull Request Description

What and why?

How to test

What needs special review?

Dependencies, breaking changes, and deployment notes

Release notes

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

api now lives under the app. hostname. This will resolve that.

Signed-off-by: Cullen Taylor <cullen@eggshell.me>
@eggshell eggshell added the internal Not to be externalized in the release notes label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

PR Summary

This PR updates the API host endpoint used for Notebook Runner tracking in both the GitHub workflow and the notebook execution script. The change replaces the previous URL 'https://api.dev.vm.validmind.ai/api/v1/tracking' with the new URL 'https://app.dev.vm.validmind.ai/api/v1/tracking'. This adjustment ensures that both the integration workflow and the end-to-end notebook execution rely on the updated endpoint for tracking-related operations.

Test Suggestions

  • Verify that the integration workflow picks up the new endpoint by running the CI pipeline and confirming that the notebooks are tracked correctly.
  • Run end-to-end tests to ensure that API calls from the notebook runner script are successfully reaching the new endpoint.
  • Mock or simulate API responses from the new host to confirm that error handling and success flows function as expected.

@eggshell eggshell merged commit 31aa849 into main May 20, 2026
8 checks passed
@eggshell eggshell deleted the cullen/sc-15688/flatten-ingress branch May 20, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants