[SC 16234] Two small fixes to built-in ValidMind tests#512
Merged
AnilSorathiya merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
PR SummaryThis PR introduces two main functional improvements:
Overall, the PR improves the robustness of data validation by avoiding the application of statistical methods to inappropriate data types and enhances the diagnostic reporting by ensuring thresholds are normalized and merged appropriately. Test Suggestions
|
juanmleng
approved these changes
May 19, 2026
Contributor
juanmleng
left a comment
There was a problem hiding this comment.
Fantastic, thanks @AnilSorathiya!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What and why?
IQROutliersBarPlot — Boolean and binary columns (≤2 unique values) are now excluded from plots and from the raw outlier summary table. Before, they could appear in raw data or cause quantile errors on boolean dtypes. After, only meaningful numeric features are analyzed.
WeakspotsDiagnosis — Custom
thresholdscan now specify only some metrics (e.g.{"accuracy": 0.65}). Before, missing keys could break plots or pass/fail logic. After, plots use defaults for metrics without a custom threshold (reference lines still show), and pass/fail only checks the thresholds you provide.How to test
Manual checks (optional):
IQROutliersBarPloton a dataset with boolean columns; confirm they are not in the bar plots or raw outlier table.WeakspotsDiagnosiswiththresholds={"accuracy": 0.65}; confirm plots show reference lines for all metrics and pass/fail only uses accuracy.What needs special review?
WeakspotsDiagnosis: split betweenplot_thresholds(defaults + overrides) andpass_thresholds(user-only when custom thresholds are passed).IQROutliersBarPlot:eligible_columnsfilter applied consistently to plots and raw data.Dependencies, breaking changes, and deployment notes
Release notes
Checklist