Skip to content

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Nov 24, 2025

The vaadinPush.js file was previously placed in META-INF/resources/VAADIN/static/push/ which is automatically served by servlet containers from both the context root and through the Vaadin servlet. This created ambiguity about which path was being used.

Move the push JS files to META-INF/VAADIN/webapp/VAADIN/static/push/ so they are:

  • NOT automatically served by the servlet container
  • ONLY served through the Vaadin static file handler
  • Located alongside other VAADIN webapp resources (themes, npm assets)

The vaadinPush.js file was previously placed in META-INF/resources/VAADIN/static/push/
which is automatically served by servlet containers from both the context root
and through the Vaadin servlet. This created ambiguity about which path was being used.

Move the push JS files to META-INF/VAADIN/webapp/VAADIN/static/push/ so they are:
- NOT automatically served by the servlet container
- ONLY served through the Vaadin static file handler
- Located alongside other VAADIN webapp resources (themes, npm assets)
@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Test Results

1 189 files   - 107  1 189 suites   - 107   1h 22m 33s ⏱️ + 7m 36s
8 861 tests  - 226  8 790 ✅  - 229  53 💤  - 15  9 ❌ +9  9 🔥 +9 
9 281 runs   - 262  9 204 ✅  - 263  59 💤  - 17  9 ❌ +9  9 🔥 +9 

For more details on these failures and errors, see this check.

Results for commit 185e450. ± Comparison against base commit db042e8.

This pull request removes 228 and adds 2 tests. Note that renamed tests count towards both.
com.vaadin.flow.ClientResourceIT ‑ clientResourcesAreNotExposed[any_Chrome_]
com.vaadin.flow.InitialExtendedClientDetailsIT ‑ verifyClientDetails[any_Chrome_]
com.vaadin.flow.uitest.ui.AllowInertSynchronizedPropertyIT ‑ modalDialogOpened_toggleNativeDetailsVisibility_allowInertSynchronizedPropertyShouldChange[any_Chrome_]
com.vaadin.flow.uitest.ui.AttachExistingElementIT ‑ attachExistingElement[any_Chrome_]
com.vaadin.flow.uitest.ui.BackButtonServerRoundTripIT ‑ testForwardingToViewInSetParameter[any_Chrome_]
com.vaadin.flow.uitest.ui.BasicComponentIT ‑ ensureDomUpdatesAndEventsDoSomething[any_Chrome_]
com.vaadin.flow.uitest.ui.BasicComponentIT ‑ tagsInText[any_Chrome_]
com.vaadin.flow.uitest.ui.BrokenRouterLinkIT ‑ testRouterLink_linkIsBroken_urlIsUpdated[any_Chrome_]
com.vaadin.flow.uitest.ui.BrokenRouterLinkIT ‑ testRouterLink_visitBrokenLinkAndBack_scrollPositionIsRetained[any_Chrome_]
com.vaadin.flow.uitest.ui.CallFunctionBeforeRemoveIT ‑ noErrorOnJSExecutionBeforeDetach[any_Chrome_]
…
com.vaadin.flow.server.StaticFileServerTest ‑ serveStaticResource_vaadinPushMinScript_servedFromMetaInfVaadinWebapp
com.vaadin.flow.server.StaticFileServerTest ‑ serveStaticResource_vaadinPushScript_servedFromMetaInfVaadinWebapp

♻️ This comment has been updated with latest results.

@sonarqubecloud
Copy link

@mshabarov mshabarov self-requested a review December 1, 2025 12:36
@Artur-
Copy link
Member Author

Artur- commented Dec 8, 2025

This apparently requires redefining from where static files are served, so let's get back to it later

@Artur- Artur- closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants