feat: add upload rejection API with optional messages #22814
+630
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
reject-file-upload
branch
from
f8f15ab to
eff2c54
Compare
Add ability to reject file uploads during processing with optional rejection messages. The rejection status is tracked per-file and communicated back to the client via appropriate HTTP status codes: - 200 OK: all files accepted - 422 Unprocessable Entity: all files rejected (with JSON body) - 207 Multi-Status: mixed results (with JSON body) Key changes: - Add reject() and reject(String) methods to UploadEvent - Extend UploadResult record with acceptedFiles/rejectedFiles tracking - Add UploadResult.Builder for incremental result construction - Move JSON response handling into UploadHandler.responseHandled() - Add rejected() callback to FileUploadCallback and InMemoryUploadCallback
Remove unnecessary UploadResult.Builder class and use direct list accumulation in TransferUtil. This simplifies the code flow by eliminating mutable state passed as method parameters, making the upload handling logic clearer and more maintainable.
Artur-
force-pushed
the
reject-file-upload
branch
from
eff2c54 to
bc1544e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to reject file uploads during processing with optional
rejection messages. The rejection status is tracked per-file and
communicated back to the client via appropriate HTTP status codes:
Key changes: