Skip to content

[oneDPL] Add more copying mutating parallel range algorithms #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

dmitriy-sobolev
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev commented Jul 28, 2025

Adding reverse_copy and unique_copy parallel range algorithms into oneDPL specification.

@akukanov akukanov added the DPL label Jul 29, 2025
@dmitriy-sobolev dmitriy-sobolev marked this pull request as draft July 30, 2025 13:39
@dmitriy-sobolev dmitriy-sobolev marked this pull request as ready for review July 30, 2025 14:16
@dmitriy-sobolev dmitriy-sobolev force-pushed the add-range-copy-algorithms branch from bb4ac30 to 987846a Compare August 5, 2025 16:11
@dmitriy-sobolev dmitriy-sobolev force-pushed the add-range-copy-algorithms branch from 987846a to a8842c6 Compare August 5, 2025 16:12
@danhoeflinger danhoeflinger self-requested a review August 6, 2025 15:05
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev
Copy link
Contributor Author

dmitriy-sobolev commented Aug 12, 2025

@danhoeflinger, sorry for dismissing your approval.

I've made a correction. Now, reverse_copy interface is compared against the standard serial one, not the parallel API from the draft. It's aligned with all other algorithms in this document.

Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reapproving

Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants