Skip to content

Comments

Add messages to the script#180

Open
Feng-12138 wants to merge 1 commit intomainfrom
yiran/add_messages_to_setup_secrets
Open

Add messages to the script#180
Feng-12138 wants to merge 1 commit intomainfrom
yiran/add_messages_to_setup_secrets

Conversation

@Feng-12138
Copy link
Contributor

Notion ticket link

Ticket Name

Implementation description

Steps to test

  1. ./setup_secrets.sh
  2. ./setup_secrets.sh
  3. ./setup_secrets.sh --output_path new_file

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@Feng-12138 Feng-12138 requested a review from billcui57 October 14, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant