Adding marshaled() to Array<Marshaling>#104
Open
pepasflo wants to merge 1 commit into
Open
Conversation
Member
|
Hey! Yeah, using As to the addition, I think that looks great. Let us mull it over for a day or two though. Recently we've had a lot of great contributions but Marshal has really started to grow beyond it's original simple and small state. Let's get some discussion @bwhiteley what do you think? I think this is a good addition. |
Member
|
Hey @pepasflo. I'm good to merge this. Would you be willing to write up a few tests? |
Author
|
@jarsen sure, good idea! I'll get this done within the next few days. |
|
Did this get merged? |
Contributor
|
I'd like to see this merged, too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Thanks for writing Marshal.
Consider these nested types:
I'm guessing the implementation of
MarshalingonGroup.memberswould look like this?Is that the expected way to do that, or did I miss something obvious?
This PR adds
MarshalingonArray<Marshaling>, so that you can do this instead: