Fix unknown framework version - #126
Merged
Merged
Conversation
Fixes #120. A pinned version absent from the framework manifest raised, but either manifest can lag a release — the bundled copy ages with the gem, and it stands in whenever the published one is unreachable, which is how a current Docker image still rejected 3.1.2. Any well-formed number is now accepted, with Gem::Version as the gate so nothing unsafe reaches the asset URLs, and #known? reports whether the manifest lists it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #120. Now instead of error, I'd warn about using non-existent framework.